Open
Conversation
kukushechkin
commented
Mar 20, 2026
.github/workflows/main.yml
Outdated
| swift_6_1_enabled: true | ||
| swift_6_2_enabled: true | ||
| swift_6_3_enabled: true | ||
| macos_xcode_test_enabled: false # Disabled because of an issue |
Contributor
Author
There was a problem hiding this comment.
Was the issue related to the CI infra or swift-nio?
Contributor
There was a problem hiding this comment.
I think infrastructure - we can circle back to this
Contributor
Author
There was a problem hiding this comment.
Let's enable it then and see what breaks?
kukushechkin
force-pushed
the
enable-tests-on-simulators
branch
from
2fda137 to
0d5ff0d
Compare
samuelmuno
reviewed
Mar 20, 2026
rnro
reviewed
Mar 20, 2026
rnro
requested changes
Mar 20, 2026
Co-authored-by: Rick Newton-Rogers <rnro@apple.com>
…hechkin/swift-log into enable-tests-on-simulators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt
swift-nioconfig for running nightly tests on simulators.Motivation:
To check if running tests on simulators is flaky or not.
Modifications:
CI main.yml is updated to include simulators, copied from
swift-nio.Result:
More tests are running.