Closed
Conversation
samuelmurray
commented
Jan 29, 2026
Comment on lines
+340
to
+349
| self.log( | ||
| level: .trace, | ||
| message(), | ||
| error: error, | ||
| metadata: metadata(), | ||
| source: source(), | ||
| file: file, | ||
| function: function, | ||
| line: line | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
It’s a bit unfortunate that we don’t call the trace method with #if !MaxLogLevelDebug && !MaxLogLevelInfo && !MaxLogLevelNotice && !MaxLogLevelWarning && !MaxLogLevelError && !MaxLogLevelCritical && !MaxLogLevelNone, but since we add a log overload as well, I thought it would make sense to call that, and so only do the metadata merging at one place.
Contributor
Author
|
Replaced with #425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft implementation of SLG-0003 #405