This repository was archived by the owner on Mar 28, 2020. It is now read-only.
[IndexStore] Enable blocks support on Linux builds#291
Open
kastiglione wants to merge 1 commit intoapple:upstream-with-swiftfrom
Open
[IndexStore] Enable blocks support on Linux builds#291kastiglione wants to merge 1 commit intoapple:upstream-with-swiftfrom
kastiglione wants to merge 1 commit intoapple:upstream-with-swiftfrom
Conversation
Contributor
Author
|
Note that the Swift 5 Linux release includes a libIndexStore.so that is missing those symbols. |
Contributor
Author
|
cc @benlangmuir |
compnerd
reviewed
Apr 10, 2019
| LINK_FLAGS ${INDEXSTORE_LINK_FLAGS}) | ||
| else() | ||
| # Blocks are off by default on non-darwin platforms. | ||
| target_compile_options(IndexStore PRIVATE -fblocks) |
Collaborator
There was a problem hiding this comment.
This can be hoisted out of the condition as it is safe to apply -fblocks when building for Darwin. However, please ensure that you do not apply this when the C++ compiler is not clang. The Windows builds use cl to build the toolchain as it is much faster and better.
| else() | ||
| # Blocks are off by default on non-darwin platforms. | ||
| target_compile_options(IndexStore PRIVATE -fblocks) | ||
| target_link_libraries(IndexStore PRIVATE BlocksRuntime) |
Collaborator
There was a problem hiding this comment.
Ugh, this is really annoying. The BlocksRuntime really should come from libdispatch, as that is the canonical one that is used elsewhere in the swift project. I don't know how to break this cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables block support for Linux builds of
IndexStore. The motivation is to have the various_applyfunctions be present (exindexstore_store_units_apply). Without this, only the function pointer variants are available (exindexstore_store_units_apply_f).