Skip to content

Added support for json5#44

Open
danhon wants to merge 4 commits intoaparrish:masterfrom
danhon:adding-json5-support
Open

Added support for json5#44
danhon wants to merge 4 commits intoaparrish:masterfrom
danhon:adding-json5-support

Conversation

@danhon
Copy link
Copy Markdown

@danhon danhon commented Dec 12, 2024

  • Switched the json module for pyjson5 to support json5 (comments, yay)

  • moved the test grammar out into its own file.

* Switched the json module for pyjson5 to support json5 (comments, yay)

* moved the test grammar out into its own file.
Copy link
Copy Markdown
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyjson5 should be listed as a dependency in install_requires here:

install_requires=[],

(pyjson5 probably doesn't support all old Python versions pytracery claims to, but pytracery should probably drop those anyway.)

README.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete this empty file, there's already a README.rst

hello.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete this file too?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure how that got in there.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants