Skip to content

fix: Complete ICHECK update across codebase#18858

Open
MasterJH5574 wants to merge 1 commit intoapache:mainfrom
MasterJH5574:tvm-dev/2026-02-28-icheck
Open

fix: Complete ICHECK update across codebase#18858
MasterJH5574 wants to merge 1 commit intoapache:mainfrom
MasterJH5574:tvm-dev/2026-02-28-icheck

Conversation

@MasterJH5574
Copy link
Contributor

Replace all references to the old ICHECK / ICHECK_EQ macro names with their TVM_FFI_ICHECK / TVM_FFI_ICHECK_EQ equivalents across source files, comments, and documentation, completing the macro rename introduced by the TVM FFI refactor.

Replace all references to the old `ICHECK` / `ICHECK_EQ` macro names with their
`TVM_FFI_ICHECK` / `TVM_FFI_ICHECK_EQ` equivalents across source files, comments,
and documentation, completing the macro rename introduced by the TVM FFI refactor.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the transition to the TVM_FFI_ICHECK and TVM_FFI_ICHECK_EQ assertion macros, which was initiated as part of the TVM FFI refactor. The changes ensure consistency throughout the codebase by replacing all remaining instances of the older ICHECK and ICHECK_EQ macros, thereby aligning the project with the updated FFI error handling mechanisms.

Highlights

  • Macro Renaming Completion: Completed the migration of assertion macros from ICHECK to TVM_FFI_ICHECK and ICHECK_EQ to TVM_FFI_ICHECK_EQ across the codebase.
  • Code and Documentation Consistency: Updated all references to the old macro names in source files, comments, and documentation to reflect the new TVM_FFI_ICHECK and TVM_FFI_ICHECK_EQ equivalents.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • 3rdparty/tensorrt_llm/custom_allreduce_kernels.cu
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • apps/ios_rpc/tvmrpc/RPCArgs.mm
    • Replaced ICHECK_EQ with TVM_FFI_ICHECK_EQ.
  • apps/ios_rpc/tvmrpc/RPCServer.mm
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • apps/ios_rpc/tvmrpc/TVMRuntime.mm
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • docs/arch/pass_infra.rst
    • Updated ICHECK macro references to TVM_FFI_ICHECK in documentation code examples.
  • docs/contribute/error_handling.rst
    • Updated ICHECK and ICHECK_EQ macro references to TVM_FFI_ICHECK and TVM_FFI_ICHECK_EQ in documentation text and code examples.
  • docs/errors.rst
    • Updated documentation to reference TVM_FFI_ICHECK and its new header path.
  • src/arith/iter_affine_map.cc
    • Updated a comment to refer to TVM_FFI_ICHECK.
  • src/relax/transform/bind_params.cc
    • Updated a comment to refer to TVM_FFI_ICHECK.
  • src/runtime/contrib/coreml/coreml_runtime.mm
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • src/runtime/contrib/cutlass/fp16_group_gemm_runner_sm100.cuh
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • src/runtime/contrib/cutlass/fp16_group_gemm_runner_sm90.cuh
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • src/runtime/contrib/cutlass/gemm_runner.cuh
    • Replaced ICHECK with TVM_FFI_ICHECK.
  • src/target/llvm/codegen_hexagon.cc
    • Updated a comment to refer to TVM_FFI_ICHECK.
  • src/tir/transform/storage_rewrite.cc
    • Updated a comment to refer to TVM_FFI_ICHECK_EQ.
  • src/tir/transform/vectorize_loop.cc
    • Updated a comment to refer to TVM_FFI_ICHECK.
Activity
  • No specific activity (comments, reviews, progress) was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a refactoring effort to replace all occurrences of the old ICHECK and ICHECK_EQ macros with their modern TVM_FFI_ICHECK and TVM_FFI_ICHECK_EQ counterparts. The changes are applied consistently across source code, comments, and documentation. The review confirms that all modifications are correct and align with the PR's objective. No issues of medium or higher severity were identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants