Don't pool origin connections with unconsumed request body#12926
Don't pool origin connections with unconsumed request body#12926JakeChampion wants to merge 4 commits intoapache:masterfrom
Conversation
f9e9fb3 to
38328b3
Compare
When an origin responds before consuming a request body sent with `Expect: 100-continue`, ATS was returning the origin connection to the pool with leftover body data in the TCP stream The next request reusing that connection would see the leftover bytes as a corrupted response Fix by recording `server_request_body_bytes` when aborting the tunnel early, then checking it in both connection pooling paths to prevent reuse when a request body was in flight
370a382 to
fc349f0
Compare
… connection pooling issues
|
I'll have a look at this. @JakeChampion are you on slack? |
I am not, I requested an invite some time last year but I don't think it's been accepted |
Ohh, sorry about that. I've just had a look and couldn't find the email. Please send another email to the users@trafficserver.apache.org list and I'll help you with that. Thanks. |
Thank you, I've just sent an email |
Unfortunately I can not send an email there
|
|
apologies. send me an email at dmeden@apache.org. Thanks. |
When an origin responds before consuming a request body sent with
Expect: 100-continue, ATS was returning the origin connection to the pool with leftover body data in the TCP streamThe next request reusing that connection would see the leftover bytes as a corrupted response
Fix by recording
server_request_body_byteswhen aborting the tunnel early, then checking it in both connection pooling paths to prevent reuse when a request body was in flight