fix(core): prefer current repo when resolving amber home path#4263
Open
carloea2 wants to merge 2 commits intoapache:mainfrom
Open
fix(core): prefer current repo when resolving amber home path#4263carloea2 wants to merge 2 commits intoapache:mainfrom
carloea2 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@chenlica Can you assign a reviewer? Thanks. |
Contributor
|
@aglinxinyuan @Xiao-zhen-Liu Please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes an issue in
amberHomePathresolution where the previous implementation could select the wrong repo when multiple sibling directories under the same parent satisfiedisAmberHomePath(...).texera/amber/src/main/scala/org/apache/texera/amber/engine/common/Utils.scala
Lines 39 to 59 in ac909a0
Previously, if the current working directory was not itself recognized as the Amber home path, the code would walk the parent directory and return
findAny()from matching paths. In environments with multiple Texera/Amber repos under the same parent, this could resolve to an unrelated sibling repo instead of the repo the process was launched from.This PR changes the logic to:
toRealPath()Files.walk(...)safely usingUsing.resource(...)This makes Amber home path detection more deterministic and prevents accidentally selecting the wrong engine/repo in multi-repo local setups.
Any related issues, documentation, discussions?
Closes #4262
How was this PR tested?
Manually tested with a local directory layout where multiple sibling repos satisfy
isAmberHomePath(...).Example setup:
Was this PR authored or co-authored using generative AI tooling?
No.