Conversation
|
@bobbai00 : please work with @gracecluvohio on this task. |
|
Dear @parshimers , I would like to know if this is a good practice. If so, what should be the email sender for such emails? I searched for things like |
Hey Jiadong, Hope that helps,
|
|
Hello @chenlica and @bobbai00 , What do you think about making the SQL DDL changes a community wide discussion instead? Perhaps we could notify developers via the dev mail list before a DDL change is merged, rather than after. That way developers have a say, or are at least aware, before a breaking change is merged. |
Thank you Ian. In this case, I think we can close this PR and define the protocol similar to Spark's SPIP. |
Hi @gracecluvohio and @chenlica , According to Ian's comment, I am leaning towards closing this PR and defining something similar to https://spark.apache.org/improvement-proposals.html. For all the changes that are non-backward-compatible, we should let developers follow this protocol. What do you guys think? |
I'm not sure. On one hand, I think having a proposal system could be helpful to ensure that developers have a say in breaking changes. However, it also seems like a very involved, lengthy process for PRs with small DDL changes. I'm not sure if the whole community needs to be involved in the review of such PRs; they just need to be notified of one, so they can keep their local instance operational. I'd like to hear what @chenlica thinks though. |
|
I prefer a protocol that can allow us to make DDL changes quickly, as in an "optimistic commit protocol." When our community gets big enough, we can use a more conservative approach. |
|
@bobbai00 Please make a decision. |
What changes were proposed in this PR?
This PR adds a workflow that automatically sends an email notifying developers on DDL change.
Please note that we will need to add GitHub secrets MAIL_USERNAME and MAIL_PASSWORD to specify which email to send the email from.
Any related issues, documentation, discussions?
Closes #4166
How was this PR tested?
Tested on my private repository.
Was this PR authored or co-authored using generative AI tooling?
Co-authored using: Claude Code (Sonnet 4.6)