fix(operator): convert booleans to Python-compatible values in BubbleChart/ContourPlot/TernaryPlot#4238
Open
xuang7 wants to merge 9 commits intoapache:mainfrom
Open
Conversation
Contributor
|
I think the best solution is to keep the previous semantics but fixing it. |
carloea2
suggested changes
Feb 26, 2026
...ain/scala/org/apache/texera/amber/operator/visualization/bubbleChart/BubbleChartOpDesc.scala
Show resolved
Hide resolved
…conversion' into fix/bubble-chart-boolean-python-conversion
xuang7
changed the title
bobbai00
changed the title
bobbai00
approved these changes
Mar 5, 2026
Contributor
bobbai00
left a comment
bobbai00
left a comment
There was a problem hiding this comment.
LGTM. Please explain briefly how the current fix solves the problem
Contributor
Author
Thanks for the suggestion. I have updated the PR description with a short explanation. |
Contributor
|
@carloea2 Is your suggested change taken care of? If so, we can merge this PR. |
Contributor
Author
Contributor
|
@chenlica this PR LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes a bug in
BubbleChartOpDesc,ContourPlotOpDesc, andTernaryPlotOpDescwhere boolean fields were interpolated into the Python template without quotes, resulting in code likeif false == 'true'. Since Python does not recognize lowercase false as a valid identifier, this caused aNameError: name 'false' is not defined. The fix wraps the variables in quotes (if '$enableColor' == 'true'), reverting to the string comparison approach used before the Python template was introduced, so the generated Python performs a string-to-string comparison.Demo:
Any related issues, documentation, discussions?
Closes #4257
How was this PR tested?
Manually tested
Was this PR authored or co-authored using generative AI tooling?
No