Skip to content

Add OOC cbind#2437

Merged
janniklinde merged 5 commits intoapache:mainfrom
jessicapriebe:ooc/operators/cbind
Mar 10, 2026
Merged

Add OOC cbind#2437
janniklinde merged 5 commits intoapache:mainfrom
jessicapriebe:ooc/operators/cbind

Conversation

@jessicapriebe
Copy link
Contributor

This adds OOC cbind.

Copy link
Contributor

@Baunsgaard Baunsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janniklinde
Copy link
Contributor

janniklinde commented Mar 9, 2026

I think there may be an issue with parallelization of parameterized tests. Maybe try adding @NotThreadSafe to the test @jessicapriebe.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.80%. Comparing base (49893a8) to head (9210d79).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...runtime/instructions/ooc/AppendOOCInstruction.java 93.26% 5 Missing and 2 partials ⚠️
...untime/instructions/ooc/SubscribableTaskQueue.java 25.00% 2 Missing and 4 partials ⚠️
...org/apache/sysds/runtime/io/WriterBinaryBlock.java 0.00% 4 Missing and 1 partial ⚠️
...va/org/apache/sysds/runtime/ooc/util/OOCUtils.java 20.00% 2 Missing and 2 partials ⚠️
.../sysds/runtime/instructions/ooc/CachingStream.java 0.00% 1 Missing ⚠️
...he/sysds/runtime/io/WriterBinaryBlockParallel.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2437      +/-   ##
============================================
+ Coverage     71.45%   71.80%   +0.35%     
- Complexity    47805    48261     +456     
============================================
  Files          1554     1555       +1     
  Lines        184605   185481     +876     
  Branches      36227    36401     +174     
============================================
+ Hits         131903   133185    +1282     
+ Misses        42449    41995     -454     
- Partials      10253    10301      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janniklinde janniklinde merged commit a3400ee into apache:main Mar 10, 2026
84 of 87 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants