Draft
Conversation
Contributor
Author
|
@grundprinzip the good question is about compatibility of type names - PySpark returns things like |
Contributor
|
So I was wondering how much we need this function. The PySpark API has some other interesting functionality to create the DDL String from a dataframe or more generally a schema to SQL string and SQL types. Personally, I would maybe pause on this PR until we have additional data type support (e.g. we're missing struct from arrow to go right now) |
Contributor
Author
|
yep, I picked it up just because it in the list, but not 100% sure how much we need it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds
DtypesfunctionWhy are the changes needed?
to make implementation on pair with Python version
Does this PR introduce any user-facing change?
How was this patch tested?
Added integration test