fix: restrict set_skywalking_url tool to stdio transport only#30
Merged
fix: restrict set_skywalking_url tool to stdio transport only#30
Conversation
Reverts the session-in-all-transports behavior from PR #29. The set_skywalking_url tool is now only registered for stdio mode, where single-client session semantics are well-defined. SSE and HTTP transports rely on per-request SW-URL headers and CLI flags instead, avoiding the shared-session issue where one client could override another's credentials. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fine0830
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_skywalking_urlsession tool to stdio transport only, reverting the session-in-all-transports behavior from PR feat: add session-based SkyWalking URL and basic auth support #29Session{}into context, avoiding the issue where one client could override another's URL/credentialsSW-URLheaders and--sw-urlCLI flag for URL configurationContext
PR #29 review feedback (from both Copilot and @Fine0830) identified that SSE and HTTP transports shared a single
Session{}across all clients, which is a correctness and security issue. Since stdio has a single client with well-defined session semantics,set_skywalking_urlis now stdio-only.Test plan
swmcp stdioregistersset_skywalking_urltool and session works as beforeswmcp sseandswmcp streamabledo NOT exposeset_skywalking_urltoolSW-URLheader >--sw-urlflag > default🤖 Generated with Claude Code