RATIS-2393 Add Span Context to RaftRpcRequestProto#1341
Open
taklwu wants to merge 9 commits intoapache:masterfrom
Open
RATIS-2393 Add Span Context to RaftRpcRequestProto#1341taklwu wants to merge 9 commits intoapache:masterfrom
taklwu wants to merge 9 commits intoapache:masterfrom
Conversation
Author
|
@szetszwo Hi Nicholas, should I directly open PRs to master branch ? in addition , the test failure doesn't seem to be related to my changes |
szetszwo
reviewed
Feb 7, 2026
Contributor
szetszwo
left a comment
There was a problem hiding this comment.
@taklwu , thanks for working on this! Please see the comment inlined.
BTW, this change is very small. Let's combine the usage of the new SpanContextProto such as RATIS-2395 or some part of it. Otherwise, it is hard to determine whether this change is good or not.
Contributor
|
@taklwu Please add license for the failed ci! |
Author
|
@OneSizeFitsQuorum I have updated the license and good catch. |
szetszwo
reviewed
Mar 3, 2026
Contributor
szetszwo
left a comment
There was a problem hiding this comment.
@taklwu , thanks for the update!
Please see the comments inlined and also https://issues.apache.org/jira/secure/attachment/13081062/1341_review.patch
ratis-common/src/main/java/org/apache/ratis/protocol/RaftClientRequest.java
Outdated
Show resolved
Hide resolved
ratis-common/src/main/java/org/apache/ratis/trace/RatisAttributes.java
Outdated
Show resolved
Hide resolved
ratis-common/src/main/java/org/apache/ratis/trace/TraceUtils.java
Outdated
Show resolved
Hide resolved
ratis-common/src/main/java/org/apache/ratis/trace/TraceUtils.java
Outdated
Show resolved
Hide resolved
ratis-common/src/main/java/org/apache/ratis/trace/TraceUtils.java
Outdated
Show resolved
Hide resolved
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
Outdated
Show resolved
Hide resolved
- First commit of using OpenTelemetry - use junit5 and default opentelemetry extension in test case. - Add test to mock client level span and inject when request is being sent - only include the server extract
1. use traceAsyncMethod 2. add ClientInvocationId 3. and other places
Author
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We're adding a new map to RaftRpcRequestProto that will be used for upcoming Opentelemetry integration.
see the usage of PoC https://github.com/taklwu/ratis/blob/opentelemetry0129/ratis-common/src/main/java/org/apache/ratis/trace/TraceUtils.java#L235-L251
Another official reference for how this map is going to be inject and extract from the http / rpc header
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2393
How was this patch tested?
running mvn clean package -DskipTests