[cleanup] Convert 10 test classes to SharedPulsarBaseTest#25338
Open
merlimat wants to merge 9 commits intoapache:masterfrom
Open
[cleanup] Convert 10 test classes to SharedPulsarBaseTest#25338merlimat wants to merge 9 commits intoapache:masterfrom
merlimat wants to merge 9 commits intoapache:masterfrom
Conversation
ClientDeduplicationTest, ConsumerDecryptFailListenerTest, InterceptorsTest, MessageChunkingSharedTest, PartialPartitionedProducerTest, PartitionedProducerConsumerTest, ProducerMemoryLeakTest, PulsarMultiHostClientTest, RetryTopicTest, TopicReaderTest
merlimat
force-pushed
the
shared-tests-convert-11a
branch
from
25d5574 to
f0e17ce
Compare
The test asserts exactly 1 ledger remains after trimming, but with maxEntriesPerLedger=2, if partition-0 receives an even number of messages, the last ledger is full and a new empty active ledger is created. The trim correctly removes all consumed ledgers but cannot remove the ledger containing the last confirmed entry or the current active ledger, leaving 2 ledgers. Change the assertion from assertEquals(size, 1) to assertTrue(size <= 2) since the number of remaining ledgers depends on whether the last write caused a rollover.
Disable dedup on the namespace to prevent the pulsar.dedup cursor from blocking ledger trimming. Use skipAllMessages (sync admin call) instead of acknowledgeCumulative (async) to reliably advance the cursor.
lhotari
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert 10 test classes from
ProducerConsumerBasetoSharedPulsarBaseTest, reducingtest execution time by sharing a single Pulsar cluster across tests.
Also enables
brokerDeduplicationEnabledin the shared cluster config (this just allowsthe feature; it doesn't enable it for all namespaces).
Converted classes:
Documentation
doc-not-needed(Changes in your PR don't need doc changes)Matching PR in forked repository
PR in forked repository: