Skip to content

OMID-284 Use protobuf 4 in Omid#170

Closed
szucsvillo wants to merge 1 commit intoapache:masterfrom
szucsvillo:OMID-284
Closed

OMID-284 Use protobuf 4 in Omid#170
szucsvillo wants to merge 1 commit intoapache:masterfrom
szucsvillo:OMID-284

Conversation

@szucsvillo
Copy link
Contributor

No description provided.

@szucsvillo szucsvillo marked this pull request as draft October 2, 2024 08:37
<protobuf-java.version>2.5.0</protobuf-java.version>
<protoc.version>2.5.0</protoc.version>
<protobuf-java.version>4.28.2</protobuf-java.version>
<protoc.version>4.28.2</protoc.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove profile for linux-aarch64

// limitations under the License.
//

syntax = "proto3";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for building with proto3? hbase still uses proto2 even though builds with proto 4.8.2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely independent of HBase, used only for communicationg with the TSO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HBase RPC is done either via protobuf 2.5 or the thirdparty protobuf.

@NihalJain
Copy link
Contributor

Also how do we deal with hadoop related tests if we donot use a shaded proto version here? Should we have a shaded protobuf similar to hbase?

@NihalJain
Copy link
Contributor

Also how do we deal with hadoop related tests if we donot use a shaded proto version here? Should we have a shaded protobuf similar to hbase?

Or may be just use hbase-thirdparty protobuf as suggested in https://issues.apache.org/jira/browse/OMID-276

@stoty
Copy link
Contributor

stoty commented Oct 13, 2025

Superceded by #202

@stoty stoty closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants