Merged
Conversation
luoyuxia
force-pushed
the
catalog-api-v1
branch
from
5f517e1 to
79f18b8
Compare
| options: &mut HashMap<String, String>, | ||
| ) -> crate::Result<Vec<String>> { | ||
| if let Some(pk) = options.remove(PRIMARY_KEY_OPTION) { | ||
| if !primary_keys.is_empty() { |
There was a problem hiding this comment.
Will this affect the the original options? We can work on a clone of options to avoid mutating the original one.
Contributor
Author
There was a problem hiding this comment.
Yes, It'll. I will make the constructor to be private to prevent user using it. Use SchemaBuilder is simpler than the constructor since SchemaBuilder accepts &str and String,
luoyuxia
force-pushed
the
catalog-api-v1
branch
2 times, most recently
from
3fdb6d0 to
e1f21c8
Compare
luoyuxia
commented
Feb 26, 2026
| /// # Errors | ||
| /// * [`crate::Error::DatabaseNotExist`] - database in identifier does not exist. | ||
| /// * [`crate::Error::TableNotExist`] - table does not exist. | ||
| async fn get_table(&self, identifier: &Identifier) -> Result<Table>; |
Contributor
Author
There was a problem hiding this comment.
both iceberg-rust and delta-rust return a rust struct instead of rust trait. And struct is simpler to use than trait. Return struct should also be fine to paimon-rust.
|
+1 |
XiaoHongbo-Hope
approved these changes
Feb 27, 2026
luoyuxia
force-pushed
the
catalog-api-v1
branch
from
e1f21c8 to
4cb5e43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #52
Brief change log
Tests
API and Format
Documentation