CI: enable NTFC tests for qemu-armv8a (arm64)#18481
CI: enable NTFC tests for qemu-armv8a (arm64)#18481szafonimateusz-mi wants to merge 3 commits intoapache:masterfrom
Conversation
github-actions
bot
added
Size: M
szafonimateusz-mi
force-pushed
the
arm64_ntfc
branch
from
c688a09 to
fe2d941
Compare
szafonimateusz-mi
dismissed stale reviews from xiaoxiang781216 and jerpelea
via
662b2ed
szafonimateusz-mi
force-pushed
the
arm64_ntfc
branch
from
fe2d941 to
662b2ed
Compare
simbit18
requested review from
jerpelea,
linguini1,
lupyuen,
michallenc and
wangchdo
szafonimateusz-mi
force-pushed
the
arm64_ntfc
branch
2 times, most recently
from
988ff81 to
a4917aa
Compare
github-actions
bot
added
the
Area: Documentation
szafonimateusz-mi
requested review from
liuguo09,
raiden00pl and
yamt
as code owners
github-actions
bot
added
Area: CI
and removed
Area: Documentation
szafonimateusz-mi
force-pushed
the
arm64_ntfc
branch
from
73ba699 to
4fcbe2d
Compare
Enable NTFC for qemu-armv8a (arm64). QEMU for aarch64 architecture should be already on Docker image, so it should work. Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
allow ntfc tests for cmake builds Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
all targets should be build if CI-realted tools was changed Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
There was a problem hiding this comment.
Thanks @szafonimateusz-mi! Wonder if we can preempt any possible spikes in usage of GitHub Runners...
(1) Do we have the Complete CI running in your repo? We can analyse the number of hours consumed by the GitHub Runners.
(2) Actually I'm very keen to analyse: How many GitHub Runner Hours are consumed across all our QEMU CI Checks? This might need more work.
(3) During High Loads: Do you think we should disable QEMU CI Checks? Maybe through a configurable flag, in some .github/*.yml file?
(4) If we're implementing the flag: I think we should exclude QEMU CI Checks during NuttX Release Builds. CI Checks are not really helpful for NuttX Release. And we always see a Spike in GitHub Runner Usage during NuttX Release Periods.
(5) Update: I think we should disable QEMU CI Checks for NuttX Apps Repo, during peak periods. Thanks :-)
@simbit18 Would you have anything to add?
4 participants
Summary
all targets should be build if CI-realted tools was changed
Impact
TODO after CI pass: how much time it adds to CI workflow
Testing
CI