Skip to content

MINIFICPP-2770 - Handle exceptions at usage side, add test#2156

Open
adamdebreceni wants to merge 3 commits intoapache:mainfrom
adamdebreceni:MINIFICPP-2770
Open

MINIFICPP-2770 - Handle exceptions at usage side, add test#2156
adamdebreceni wants to merge 3 commits intoapache:mainfrom
adamdebreceni:MINIFICPP-2770

Conversation

@adamdebreceni
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@adamdebreceni adamdebreceni changed the title MINIFICPP-2770 - Centralize exception handling, add test MINIFICPP-2770 - Handle exceptions at usage side, add test Apr 10, 2026
Copy link
Copy Markdown
Member

@szaszm szaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor, thanks! I didn't consider this when reading the previous PR, but I like this macro-free solution better

adamdebreceni and others added 2 commits April 10, 2026 11:52
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants