MINIFICPP-2644 Add proxy controller service support for GCP processors#2112
Open
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2644_aws_azurefrom
Open
MINIFICPP-2644 Add proxy controller service support for GCP processors#2112lordgamez wants to merge 2 commits intoapache:MINIFICPP-2644_aws_azurefrom
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2644_aws_azurefrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds proxy controller service support to GCP processors (PutGCSObject, FetchGCSObject, ListGCSBucket, and DeleteGCSObject). The implementation follows the same pattern used in AWS and Azure processors by adding a "Proxy Configuration Service" property that accepts a ProxyConfigurationServiceInterface controller service.
Changes:
- Added proxy configuration support to the base GCSProcessor class
- Added integration tests for proxy functionality using HTTP and HTTPS proxy types
- Updated processor documentation to include the new proxy configuration property
- Improved container deployment logic to prevent redeployment of already-deployed containers
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/gcp/processors/GCSProcessor.h | Added ProxyConfigurationService property definition and proxy_ member variable to support proxy configuration |
| extensions/gcp/processors/GCSProcessor.cpp | Implemented proxy configuration parsing in onSchedule() and proxy application in getClient() |
| extensions/gcp/tests/features/google_cloud_storage.feature | Added integration test scenarios for PutGCSObject, FetchGCSObject, ListGCSBucket, and DeleteGCSObject with HTTP and HTTPS proxy support; changed "When the MiNiFi instance starts up" to "When all instances start up" for consistency |
| PROCESSORS.md | Updated documentation for DeleteGCSObject, FetchGCSObject, ListGCSBucket, and PutGCSObject to include the new Proxy Configuration Service property |
| behave_framework/src/minifi_test_framework/containers/container.py | Added is_deployed() method and check to prevent redeployment of already-deployed containers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fa7ded8 to
99207e1
Compare
a72bec3 to
9c8ac7f
Compare
fgerlits
approved these changes
Mar 26, 2026
martinzink
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2644
Depends on
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.