Skip to content

MINIFICPP-2644 Add proxy controller service support for GCP processors#2112

Open
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2644_aws_azurefrom
lordgamez:MINIFICPP-2644_gcp
Open

MINIFICPP-2644 Add proxy controller service support for GCP processors#2112
lordgamez wants to merge 2 commits intoapache:MINIFICPP-2644_aws_azurefrom
lordgamez:MINIFICPP-2644_gcp

Conversation

@lordgamez
Copy link
Copy Markdown
Contributor

@lordgamez lordgamez commented Feb 18, 2026

https://issues.apache.org/jira/browse/MINIFICPP-2644

Depends on


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds proxy controller service support to GCP processors (PutGCSObject, FetchGCSObject, ListGCSBucket, and DeleteGCSObject). The implementation follows the same pattern used in AWS and Azure processors by adding a "Proxy Configuration Service" property that accepts a ProxyConfigurationServiceInterface controller service.

Changes:

  • Added proxy configuration support to the base GCSProcessor class
  • Added integration tests for proxy functionality using HTTP and HTTPS proxy types
  • Updated processor documentation to include the new proxy configuration property
  • Improved container deployment logic to prevent redeployment of already-deployed containers

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
extensions/gcp/processors/GCSProcessor.h Added ProxyConfigurationService property definition and proxy_ member variable to support proxy configuration
extensions/gcp/processors/GCSProcessor.cpp Implemented proxy configuration parsing in onSchedule() and proxy application in getClient()
extensions/gcp/tests/features/google_cloud_storage.feature Added integration test scenarios for PutGCSObject, FetchGCSObject, ListGCSBucket, and DeleteGCSObject with HTTP and HTTPS proxy support; changed "When the MiNiFi instance starts up" to "When all instances start up" for consistency
PROCESSORS.md Updated documentation for DeleteGCSObject, FetchGCSObject, ListGCSBucket, and PutGCSObject to include the new Proxy Configuration Service property
behave_framework/src/minifi_test_framework/containers/container.py Added is_deployed() method and check to prevent redeployment of already-deployed containers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lordgamez lordgamez force-pushed the MINIFICPP-2644_aws_azure branch from fa7ded8 to 99207e1 Compare March 10, 2026 16:27
@lordgamez lordgamez force-pushed the MINIFICPP-2644_gcp branch from a72bec3 to 9c8ac7f Compare March 10, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants