Use a regular expression to not consider comma between quote while co…#9310
Use a regular expression to not consider comma between quote while co…#9310YannLeCorse wants to merge 1 commit intoapache:masterfrom
Conversation
platform/core.netigso/src/org/netbeans/core/netigso/Netigso.java
Outdated
Show resolved
Hide resolved
abe145f to
627578c
Compare
|
In general this looks sane to me. Specially thanks for the added test. Please check the author information though the "Paperwork" check ensures that author information is valid and the assumption, that a real name consists of at least two parts that are separated by a space. Have a look at https://github.com/apache/netbeans/pull/9310.patch (or your preferred git client that shows real author information), line "From: ". I'm aware that there are countries/regions where a single name is common and if that is the case, no problem, if that does not apply to you, please adjust the author information. Thank you. |
|
@YannLeCorse before I forget this: changing author information requires a forced push. Contrary to normal pushes to PR branches, forced pushed don't result in information from github sent to reviewers, so if you do that, please also add a comment. |
627578c to
35f5c73
Compare
|
@matthiasblaesing Author info should be fixed now. Thanks again. |
|
Thank you for the update. From the code perspective this looks sane to me. I'm in the region of nitpicking. The commit message should describe why a change was done (and if huge give a summary of the changes). A quick idea: This is a suggestion, feel free to rephrase of course. |
This PR addresses the issue described in #9309.
Rather than splitting on comma, we are using a regular expression to ignore the comma that are between a pair of quotes.
By doing that, we properly the exported packages even if the input string contains syntax like
org.sample.pkg1;version="1.0.0";uses:="fr.free.ylc,fr.free.ylc.sample",org.sample.pkg2;version="1.0.0"