Skip to content

Java: Additional flag to name conversion for SYNCHRONIZED_OR_ACC_SUPER and VOLATILE_OR_ACC_BRIDGE #9296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthiasblaesing merged 1 commit into from
Mar 27, 2026
Merged

Java: Additional flag to name conversion for SYNCHRONIZED_OR_ACC_SUPER and VOLATILE_OR_ACC_BRIDGE #9296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions java/java.source.base/src/org/netbeans/modules/java/source/pretty/VeryPretty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2901,17 +2901,7 @@ else if (addSpace)
needSpace();
}
}

private static final String[] flagLowerCaseNames = new String[FlagsEnum.values().length];

static {
for (FlagsEnum flag : FlagsEnum.values()) {
flagLowerCaseNames[flag.ordinal()] = flag.name().toLowerCase(Locale.ENGLISH);
}
flagLowerCaseNames[FlagsEnum.NON_SEALED.ordinal()] = "non-sealed";
flagLowerCaseNames[FlagsEnum.TRANSIENT_OR_ACC_VARARGS.ordinal()] = "transient"; //TODO: there should be a test in java.source.base for this
}


/**
* Workaround for defect #239258. Prints flag names converted to lowercase in ENGLISH locale to
* avoid weird Turkish I > i-without-dot-above conversion.
Expand All @@ -2925,7 +2915,8 @@ public static String flagNames(long flags) {
String sep = ""; // NOI18N
for (FlagsEnum flag : Flags.asFlagSet(flags)) {
buf.append(sep);
String fname = flagLowerCaseNames[flag.ordinal()];
// Since JDK26 javac FlagsEnum#toString is usable for printing
String fname = flag.toString();
buf.append(fname);
sep = " "; // NOI18N
}
Expand Down
Loading