Open
Conversation
Code was trying to disable MAC address filtering for multicast but configuration was done before HAL_ETH_Init that disabled it again. Now multicast filtering is off. No conditional for H7 device as HAL api is common for F4,F7,H7,H5 devices. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code was trying to disable MAC address filtering
for multicast but configuration was done before
HAL_ETH_Init that disabled it again.
Now multicast filtering is off.
No conditional for H7 device as HAL api is common
for F4,F7,H7,H5 devices.