MNG-11800 Exclude Eclipse IDE files and stale build artifacts from …#11801
Open
achyuth8055 wants to merge 1 commit intoapache:masterfrom
Open
MNG-11800 Exclude Eclipse IDE files and stale build artifacts from …#11801achyuth8055 wants to merge 1 commit intoapache:masterfrom
achyuth8055 wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the root build configuration to prevent Apache RAT license checks from scanning Eclipse IDE metadata and a known stale artifact file, aligning RAT’s exclusions with patterns already ignored by Git.
Changes:
- Add RAT excludes for Eclipse project files:
.classpath,.project, and.settings/** - Add RAT exclude for
.plxarcstale build artifact files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
pom.xml
Outdated
| <!-- | ||
| ! Exclude build output files that may exist in stale or non-module directories | ||
| --> | ||
| <exclude>**/.plxarc</exclude> |
…RAT checks RAT was scanning files that should be ignored: - Eclipse IDE files (.classpath, .project, .settings/) which are not cleaned by mvn clean - .plxarc files in stale/non-module target directories These patterns are already in .gitignore but RAT uses its own exclude configuration. Added the corresponding excludes to the apache-rat-plugin configuration in the root pom.xml.
achyuth8055
force-pushed
the
fix/rat-exclude-ide-and-stale-files
branch
from
ee586af to
e5b18ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11800
Problem :
RAT license checks were failing because it was scanning files that shouldn't
be checked — Eclipse IDE files (.classpath, .project, .settings/) and stale
build artifacts (.plxarc). These patterns are already in .gitignore but RAT
uses its own exclude configuration.
Added 4 exclude patterns to the apache-rat-plugin configuration in the root pom.xml:
**/.classpath**/.project**/.settings/****/.plxarc