Closed
Conversation
Adapt code to breaking API changes introduced in domtrip 0.5.0: - Rename Element.child() to Element.childElement() - Rename Element.children() to Element.childElements() - Rename ContainerNode.removeNode() to ContainerNode.removeChild() Work around missing equals/hashCode in Coordinates class (converted from record to class in 0.5.0 without adding them): - Use toGAV() string comparison instead of Coordinates.equals() Closes #11766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11766 — supersedes the dependabot PR by adapting code to breaking API changes.
domtripVersionfrom 0.4.1 to 0.6.0Element.child()→childElement(),Element.children()→childElements(),ContainerNode.removeNode()→removeChild()equals()/hashCode()inCoordinatesclass (was arecord, converted to regular class in 0.5.0 without adding them) by usingtoGAV()string comparisonChanges
pom.xml: Version bumpmvnupstrategy classes and tests: Renamed method calls to match new domtrip APIGAVUtilsTest: UsetoGAV()string comparison forCoordinatesequality checksInferenceStrategy: UsetoGAV()comparison inisParentInReactor()