Skip to content

feat: Improve the matching of required versions#11770

Open
nielsbasjes wants to merge 1 commit intoapache:maven-3.9.xfrom
nielsbasjes:ReqVersionMatch
Open

feat: Improve the matching of required versions#11770
nielsbasjes wants to merge 1 commit intoapache:maven-3.9.xfrom
nielsbasjes:ReqVersionMatch

Conversation

@nielsbasjes
Copy link
Contributor

@cstamas Followup of this discussion on Slack https://the-asf.slack.com/archives/C7Q9JB404/p1773056234905829?thread_ts=1773053661.648449&cid=C7Q9JB404

When people write in (for example) the maven-invoker-plugin something like invoker.toolchain.jdk.version = 11 it is implemented as an exact match on the mentioned version specified in the toolchains.xml .
Historically people would write this config manually and then the exact version 11 works as expected.

With the automatic generation of the toolchains.xml more places will contain the full version of the JDK like <version>11.0.29</version> instead of the more simple <version>11</version>.

The effect of people using these automatically generated toolchains.xml files is that now things still work as designed, but not as expected.

This is a quick implementation of my proposal to simply treat the requirement of a single number X as "the major version must be X".
I have also included the same for a "major.minor" requirement to accept all patch versions under that also.

This means a change from a mismatch to a match in cases like this:

matcher = RequirementMatcherFactory.createVersionMatcher("1.5.2");
matcher.matches("1.5");

I'm unsure if this change is "too breaking" to be implemented.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.

  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.

  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.

  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.

  • You have run the Core IT successfully.

  • I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

  • In any other case, please file an Apache Individual Contributor License Agreement.

@cstamas
Copy link
Member

cstamas commented Mar 11, 2026

Take a peek at "counter pr" #11786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants