feat: Improve the matching of required versions#11770
Open
nielsbasjes wants to merge 1 commit intoapache:maven-3.9.xfrom
Open
feat: Improve the matching of required versions#11770nielsbasjes wants to merge 1 commit intoapache:maven-3.9.xfrom
nielsbasjes wants to merge 1 commit intoapache:maven-3.9.xfrom
Conversation
Member
|
Take a peek at "counter pr" #11786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cstamas Followup of this discussion on Slack https://the-asf.slack.com/archives/C7Q9JB404/p1773056234905829?thread_ts=1773053661.648449&cid=C7Q9JB404
When people write in (for example) the maven-invoker-plugin something like
invoker.toolchain.jdk.version = 11it is implemented as an exact match on the mentioned version specified in the toolchains.xml .Historically people would write this config manually and then the exact version
11works as expected.With the automatic generation of the toolchains.xml more places will contain the
fullversion of the JDK like<version>11.0.29</version>instead of the more simple<version>11</version>.The effect of people using these automatically generated toolchains.xml files is that now things still work as designed, but not as expected.
This is a quick implementation of my proposal to simply treat the requirement of a single number X as "the major version must be X".
I have also included the same for a "major.minor" requirement to accept all patch versions under that also.
This means a change from a mismatch to a match in cases like this:
I'm unsure if this change is "too breaking" to be implemented.
Following this checklist to help us incorporate your contribution quickly and easily:
Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
You have run the Core IT successfully.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.