Skip to content

Migration to JUnit 5 - avoid using AbstractMojoTestCase #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
slawekjaranowski wants to merge 2 commits into
base: maven-install-plugin-3.x
Choose a base branch
from
+240 −410
Draft

Migration to JUnit 5 - avoid using AbstractMojoTestCase #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42747bc
Migration to JUnit 5 - avoid using AbstractMojoTestCase
slawekjaranowski Mar 5, 2026
1efaca5
Migration to JUnit 5 - avoid using AbstractMojoTestCase
slawekjaranowski Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,8 @@
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -180,6 +179,12 @@
<version>4.11.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-junit-jupiter</artifactId>
<version>4.11.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-nop</artifactId>
Expand Down
97 changes: 55 additions & 42 deletions src/test/java/org/apache/maven/plugins/install/InstallFileMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.apache.maven.execution.MavenSession;
import org.apache.maven.model.Model;
import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
import org.apache.maven.plugin.testing.AbstractMojoTestCase;
import org.apache.maven.project.DefaultProjectBuildingRequest;
import org.apache.maven.project.ProjectBuildingRequest;
import org.codehaus.plexus.util.FileUtils;
Expand All @@ -37,13 +36,19 @@
import org.eclipse.aether.repository.LocalRepository;
import org.eclipse.aether.repository.NoLocalRepositoryManagerException;

import static org.apache.maven.api.plugin.testing.MojoExtension.getBasedir;
import static org.apache.maven.api.plugin.testing.MojoExtension.getVariableValueFromObject;
import static org.apache.maven.api.plugin.testing.MojoExtension.setVariableValueToObject;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

/**
* @author <a href="mailto:aramirez@apache.org">Allan Ramirez</a>
*/
public class InstallFileMojoTest extends AbstractMojoTestCase {
public class InstallFileMojoTest {
private String groupId;

private String artifactId;
Expand All @@ -61,19 +66,19 @@ public class InstallFileMojoTest extends AbstractMojoTestCase {
private static final String SPECIFIC_LOCAL_REPO = "target/specific-local-repo/";

public void setUp() throws Exception {
super.setUp();
// super.setUp();

FileUtils.deleteDirectory(new File(getBasedir() + "/" + LOCAL_REPO));
FileUtils.deleteDirectory(new File(getBasedir() + "/" + SPECIFIC_LOCAL_REPO));
}

public void testInstallFileFromLocalRepositoryToLocalRepositoryPath() throws Exception {
public void testInstallFileFromLocalRepositoryToLocalRepositoryPath(InstallFileMojo mojo) throws Exception {
File localRepository =
new File(getBasedir(), "target/test-classes/unit/install-file-from-local-repository-test/target");

File testPom = new File(localRepository.getParentFile(), "plugin-config.xml");
// File testPom = new File(localRepository.getParentFile(), "plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand All @@ -95,16 +100,17 @@ public void testInstallFileFromLocalRepositoryToLocalRepositoryPath() throws Exc
assertTrue(installedArtifact.exists());

assertEquals(
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).toString(),
5,
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).size());
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).size(),
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).toString());
}

public void testInstallFileWithLocalRepositoryPath() throws Exception {
File testPom =
new File(getBasedir(), "target/test-classes/unit/install-file-with-checksum/" + "plugin-config.xml");
public void testInstallFileWithLocalRepositoryPath(InstallFileMojo mojo) throws Exception {
// File testPom =
// new File(getBasedir(), "target/test-classes/unit/install-file-with-checksum/" +
// "plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand All @@ -126,25 +132,27 @@ public void testInstallFileWithLocalRepositoryPath() throws Exception {
assertTrue(installedArtifact.exists());

assertEquals(
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).toString(),
5,
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).size());
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).size(),
FileUtils.getFiles(new File(SPECIFIC_LOCAL_REPO), null, null).toString());
}

public void testInstallFileTestEnvironment() throws Exception {
File testPom = new File(getBasedir(), "target/test-classes/unit/install-file-basic-test/plugin-config.xml");
public void testInstallFileTestEnvironment(InstallFileMojo mojo) throws Exception {
// File testPom = new File(getBasedir(),
// "target/test-classes/unit/install-file-basic-test/plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

setVariableValueToObject(mojo, "session", createMavenSession(LOCAL_REPO));

assertNotNull(mojo);
}

public void testBasicInstallFile() throws Exception {
File testPom = new File(getBasedir(), "target/test-classes/unit/install-file-basic-test/plugin-config.xml");
public void testBasicInstallFile(InstallFileMojo mojo) throws Exception {
// File testPom = new File(getBasedir(),
// "target/test-classes/unit/install-file-basic-test/plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand All @@ -164,11 +172,12 @@ public void testBasicInstallFile() throws Exception {
assertEquals(5, FileUtils.getFiles(new File(LOCAL_REPO), null, null).size());
}

public void testInstallFileWithClassifier() throws Exception {
File testPom =
new File(getBasedir(), "target/test-classes/unit/install-file-with-classifier/plugin-config.xml");
public void testInstallFileWithClassifier(InstallFileMojo mojo) throws Exception {
// File testPom =
// new File(getBasedir(),
// "target/test-classes/unit/install-file-with-classifier/plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand All @@ -190,11 +199,12 @@ public void testInstallFileWithClassifier() throws Exception {
assertEquals(5, FileUtils.getFiles(new File(LOCAL_REPO), null, null).size());
}

public void testInstallFileWithGeneratePom() throws Exception {
File testPom =
new File(getBasedir(), "target/test-classes/unit/install-file-test-generatePom/plugin-config.xml");
public void testInstallFileWithGeneratePom(InstallFileMojo mojo) throws Exception {
// File testPom =
// new File(getBasedir(),
// "target/test-classes/unit/install-file-test-generatePom/plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand Down Expand Up @@ -233,11 +243,12 @@ public void testInstallFileWithGeneratePom() throws Exception {
assertEquals(5, FileUtils.getFiles(new File(LOCAL_REPO), null, null).size());
}

public void testInstallFileWithPomFile() throws Exception {
File testPom =
new File(getBasedir(), "target/test-classes/unit/install-file-with-pomFile-test/plugin-config.xml");
public void testInstallFileWithPomFile(InstallFileMojo mojo) throws Exception {
// File testPom =
// new File(getBasedir(),
// "target/test-classes/unit/install-file-with-pomFile-test/plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand Down Expand Up @@ -268,11 +279,12 @@ public void testInstallFileWithPomFile() throws Exception {
assertEquals(5, FileUtils.getFiles(new File(LOCAL_REPO), null, null).size());
}

public void testInstallFileWithPomAsPackaging() throws Exception {
File testPom = new File(
getBasedir(), "target/test-classes/unit/install-file-with-pom-as-packaging/" + "plugin-config.xml");
public void testInstallFileWithPomAsPackaging(InstallFileMojo mojo) throws Exception {
// File testPom = new File(
// getBasedir(), "target/test-classes/unit/install-file-with-pom-as-packaging/" +
// "plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand All @@ -296,11 +308,12 @@ public void testInstallFileWithPomAsPackaging() throws Exception {
assertEquals(4, FileUtils.getFiles(new File(LOCAL_REPO), null, null).size());
}

public void testInstallFile() throws Exception {
File testPom =
new File(getBasedir(), "target/test-classes/unit/install-file-with-checksum/" + "plugin-config.xml");
public void testInstallFile(InstallFileMojo mojo) throws Exception {
// File testPom =
// new File(getBasedir(), "target/test-classes/unit/install-file-with-checksum/" +
// "plugin-config.xml");

InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);
// InstallFileMojo mojo = (InstallFileMojo) lookupMojo("install-file", testPom);

assertNotNull(mojo);

Expand All @@ -318,9 +331,9 @@ public void testInstallFile() throws Exception {
assertTrue(installedArtifact.exists());

assertEquals(
FileUtils.getFiles(new File(LOCAL_REPO), null, null).toString(),
5,
FileUtils.getFiles(new File(LOCAL_REPO), null, null).size());
FileUtils.getFiles(new File(LOCAL_REPO), null, null).size(),
FileUtils.getFiles(new File(LOCAL_REPO), null, null).toString());
}

private void assignValuesForParameter(Object obj) throws Exception {
Expand Down
Loading