GCS: Throw NotFoundException for inexistent input GCS file#15734
Open
findinpath wants to merge 1 commit intoapache:mainfrom
Open
GCS: Throw NotFoundException for inexistent input GCS file#15734findinpath wants to merge 1 commit intoapache:mainfrom
findinpath wants to merge 1 commit intoapache:mainfrom
Conversation
c82b008 to
d2f525d
Compare
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java
Outdated
Show resolved
Hide resolved
d2f525d to
cdde9bd
Compare
Signal to the TableOperations that there is no retry needed for files which do not exist.
cdde9bd to
44820f1
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal early to the TableOperations that there is no retry needed for files which do not exist.
Additional context
Relevant
apache/icebergcode using this changeiceberg/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
Lines 194 to 200 in a114e95
Issue found while testing GCS credentials vending on
apache/iceberg-rest-fixture:1.10.1ontrinodb/trinotrinodb/trino#28423