Spark: Add session property for time-travel default timestamp#15193
Open
michalheld wants to merge 1 commit intoapache:mainfrom
Open
Spark: Add session property for time-travel default timestamp#15193michalheld wants to merge 1 commit intoapache:mainfrom
michalheld wants to merge 1 commit intoapache:mainfrom
Conversation
michalheld
force-pushed
the
15163
branch
2 times, most recently
from
b7ceb6b to
adff1f1
Compare
Author
|
CC: @RussellSpitzer |
korzepadawid
approved these changes
Feb 2, 2026
jzhuge
suggested changes
Feb 2, 2026
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java
Outdated
Show resolved
Hide resolved
michalheld
force-pushed
the
15163
branch
3 times, most recently
from
d0b428c to
097d63e
Compare
Author
|
@bryanck @RussellSpitzer |
Contributor
|
Thanks for the PR @michalheld , can you update this to only apply to the latest version of Spark (4.1)? The general approach the Iceberg community takes is to first make a change to the latest version of Spark, once that is merged, open PRs to backport to other versions of Spark. |
Author
|
Thanks @bryanck for the review. I have removed changes from versions other than Spark 4.1. |
bryanck
reviewed
Mar 6, 2026
...1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
Outdated
Show resolved
Hide resolved
bryanck
reviewed
Mar 6, 2026
...1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java
Show resolved
Hide resolved
bryanck
reviewed
Mar 6, 2026
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java
Outdated
Show resolved
Hide resolved
bryanck
reviewed
Mar 6, 2026
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java
Outdated
Show resolved
Hide resolved
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java
Outdated
Show resolved
Hide resolved
Contributor
|
Also I think there is a major change in Spark 4.1 that will impact this and you might want to rebase on top of it. |
michalheld
force-pushed
the
15163
branch
2 times, most recently
from
fe3a293 to
96d6064
Compare
Adds spark.sql.iceberg.read.as-of-timestamp session property to allow setting a default timestamp for time-travel queries across all table reads when no explicit snapshot-id, as-of-timestamp, branch, or tag is specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds spark.sql.iceberg.read.as-of-timestamp session property to allow setting a default timestamp for time-travel queries across all table reads when no explicit snapshot-id, as-of-timestamp, branch, or tag is specified.
Closes #15163