[GLUTEN-11752] Fix AdaptiveSparkPlanExec accessibility in columnar write optimization#11753
Open
wangyum wants to merge 4 commits intoapache:mainfrom
Open
[GLUTEN-11752] Fix AdaptiveSparkPlanExec accessibility in columnar write optimization#11753wangyum wants to merge 4 commits intoapache:mainfrom
wangyum wants to merge 4 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
2 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Member
|
was it fixed by apache/spark#53620? |
Member
…mization Refactor GlutenWriterColumnarRules to preserve AdaptiveSparkPlanExec in plan hierarchy, enabling shuffle IDs retrieval that was broken by Spark PR #51432. Original implementation wrapped AdaptiveSparkPlanExec with ColumnarToCarrierRow, hiding it from external pattern matching. New approach wraps the input plan first, then creates a new AdaptiveSparkPlanExec with the wrapped child and supportsColumnar=false. Added GlutenWriterColumnarRulesSuite for Spark 4.0 and 4.1 to verify the fix.
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This pr fixes the issue where Gluten's columnar writer optimization breaks shuffle IDs retrieval introduced in Spark PR #51432.
Spark expects to access
AdaptiveSparkPlanExec.shuffleIdsvia pattern matching:This PR refactored the wrapping logic to:
aqe.inputPlanwithgenColumnarToCarrierRow()first →ColumnarToCarrierRow(inputPlan)AdaptiveSparkPlanExecwith the wrapped child →AdaptiveSparkPlanExec(ColumnarToCarrierRow(...))supportsColumnar=falsesince the child is already columnarThis preserves
AdaptiveSparkPlanExecin the plan hierarchy while maintaining the columnar write optimization benefits.How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.
Fixes #11752