Skip to content

FINERACT-2513: Refactor CreditBureauConfiguration integration tests to use fineract-client#5560

Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2513/credit-bureau-config-client-migration
Open

FINERACT-2513: Refactor CreditBureauConfiguration integration tests to use fineract-client#5560
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2513/credit-bureau-config-client-migration

Conversation

@DeathGun44
Copy link
Contributor

Description

Migrates CreditBureauConfigurationHelper and its callers from deprecated REST-assured to fineract-client. Removes 12 deprecated methods, adds 5 new static methods using Calls.ok() + CreditBureauConfigurationApi.

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the Jira ticket to reflect that this change is being done in the integration test. Currently the title transmit another idea.

@DeathGun44 DeathGun44 force-pushed the FINERACT-2513/credit-bureau-config-client-migration branch from 50bb14a to efb2def Compare March 1, 2026 04:38
@DeathGun44 DeathGun44 changed the title FINERACT-2513: Migrate CreditBureauConfigurationHelper to fineract-client FINERACT-2513: Refactor CreditBureauConfiguration integration tests to use fineract-client Mar 1, 2026
@DeathGun44
Copy link
Contributor Author

@IOhacker Done!

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants