FINERACT-2455: Working Capital Loan COB Job by somasorosdpc · Pull Request #5539 · apache/fineract

somasorosdpc · 2026-02-24T15:00:24Z

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Write the commit message as per our guidelines
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow our coding conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

fineract-cob/src/main/java/org/apache/fineract/cob/converter/COBParameterConverter.java

adamsaghy · 2026-02-26T09:36:28Z

...ct-cob/src/main/java/org/apache/fineract/cob/domain/CustomLoanAccountLockRepositoryImpl.java

        entityManager.flush();
    }
+
+    @Override


This seems incorrect.

adamsaghy · 2026-02-26T09:36:50Z

...ct-cob/src/main/java/org/apache/fineract/cob/domain/CustomLoanAccountLockRepositoryImpl.java

Missing solutions for WC loan

adamsaghy · 2026-02-26T09:37:35Z

...loan/src/main/resources/db/changelog/tenant/module/workingcapitalloan/parts/0002_wcp_cob.xml

+    </changeSet>
+    <changeSet id="1771924953381-1"
+               author="fineract">
+        <createTable tableName="m_wcp_loan_account_locks">


m_wc_ please

adamsaghy · 2026-02-26T09:38:03Z

...ct-working-capital-loan/src/main/java/org/apache/fineract/cob/domain/WCPLoanAccountLock.java

+import lombok.NoArgsConstructor;
+
+@Entity
+@Table(name = "m_wcp_loan_account_locks")


m_wc_ is enough

fineract-cob/src/main/java/org/apache/fineract/cob/domain/LockOwner.java

adamsaghy · 2026-02-26T09:42:48Z

fineract-cob/src/main/java/org/apache/fineract/cob/domain/AccountLockRepository.java


-public interface LoanAccountLockRepository
-        extends CustomLoanAccountLockRepository, JpaRepository<LoanAccountLock, Long>, JpaSpecificationExecutor<LoanAccountLock> {
+public interface AccountLockRepository<T extends AccountLock>


If you use AccountLockRepository as the common interface, but no extend JpaRepository and no JpaSpecificationExecutor .
This contains the methods of common functionality.

Then have 2 new interface:

LoanAccountLockRepository which contains the specific removeLockByOwner

WorkingCapitalAccountLockRepository which contains the specific removeLockByOwner.

You can mark this interface with @NoRepositoryBean

...rking-capital-loan/src/main/java/org/apache/fineract/cob/loan/WCPAccountLockServiceImpl.java

...-loan/src/main/java/org/apache/fineract/cob/wcploan/businessstep/WCPLoanCOBBusinessStep.java

adamsaghy · 2026-02-27T12:37:39Z

...ovider/src/main/java/org/apache/fineract/cob/domain/CustomLoanAccountLockRepositoryImpl.java

@@ -52,4 +52,5 @@ and lck.lock_owner in ('LOAN_COB_CHUNK_PROCESSING','LOAN_INLINE_COB_PROCESSING')
        entityManager.createNativeQuery(sql).executeUpdate();
        entityManager.flush();
    }
+


Instead of using native query can we use a Specification / CriteriaBuilder?

fineract-cob/src/main/java/org/apache/fineract/cob/service/AbstractAccountLockService.java

fineract-cob/src/main/resources/jpa/static-weaving/module/fineract-cob/persistence.xml

.../fineract/infrastructure/jobs/service/jobparameterprovider/AbstractJobParameterProvider.java

adamsaghy · 2026-02-27T12:57:33Z

...c/main/java/org/apache/fineract/cob/workingcapitalloan/WorkingCapitalLoanCOBPartitioner.java

+
+    @NonNull
+    @Override
+    public Map<String, ExecutionContext> partition(int gridSize) {


Please make sure we dont duplicate common logics, like this.

somasorosdpc force-pushed the FINERACTR-2455/working-capital-cob branch from b78203a to b74593f Compare February 25, 2026 15:45

adamsaghy reviewed Feb 26, 2026

View reviewed changes

fineract-cob/src/main/java/org/apache/fineract/cob/converter/COBParameterConverter.java Show resolved Hide resolved

adamsaghy reviewed Feb 26, 2026

View reviewed changes

fineract-cob/src/main/java/org/apache/fineract/cob/domain/LockOwner.java Outdated Show resolved Hide resolved

adamsaghy reviewed Feb 26, 2026

View reviewed changes

...rking-capital-loan/src/main/java/org/apache/fineract/cob/loan/WCPAccountLockServiceImpl.java Outdated Show resolved Hide resolved

adamsaghy reviewed Feb 26, 2026

View reviewed changes

...-loan/src/main/java/org/apache/fineract/cob/wcploan/businessstep/WCPLoanCOBBusinessStep.java Outdated Show resolved Hide resolved

somasorosdpc force-pushed the FINERACTR-2455/working-capital-cob branch from 61aac8f to 99906d5 Compare February 27, 2026 12:25