Skip to content

feat: Improved UX in the Coordinator Dynamic Config form for server selection in Decommissioning servers and Turbo Loading servers #19254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
capistrant wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: Improved UX in the Coordinator Dynamic Config form for server selection in Decommissioning servers and Turbo Loading servers #19254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74970a5
Improve host selectors in coordinator dynamic config form for decom a…
capistrant Apr 1, 2026
a0762af
fix formatting issues and import issues
capistrant Apr 1, 2026
6149005
add missing tests
capistrant Apr 1, 2026
9cb6c62
fixup file location and snapshot
capistrant Apr 1, 2026
c0897c9
add behavior tests
capistrant Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web-console/src/components/header-bar/header-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,7 @@ export const HeaderBar = React.memo(function HeaderBar(props: HeaderBarProps) {
{doctorDialogOpen && <DoctorDialog onClose={() => setDoctorDialogOpen(false)} />}
{coordinatorDynamicConfigDialogOpen && (
<CoordinatorDynamicConfigDialog
capabilities={capabilities}
onClose={() => setCoordinatorDynamicConfigDialogOpen(false)}
/>
)}
Expand Down
289 changes: 289 additions & 0 deletions .../coordinator-dynamic-config-dialog/__snapshots__/server-multi-select-dialog.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,289 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`ServerMultiSelectDialog matches snapshot when servers are loading 1`] = `
<Blueprint5.Dialog
canOutsideClickClose={true}
className="server-multi-select-dialog"
isOpen={true}
onClose={[Function]}
title="Decommissioning nodes"
>
<Memo(Loader) />
</Blueprint5.Dialog>
`;

exports[`ServerMultiSelectDialog matches snapshot with existing selection 1`] = `
<Blueprint5.Dialog
canOutsideClickClose={true}
className="server-multi-select-dialog"
isOpen={true}
onClose={[Function]}
title="Turbo loading nodes"
>
<React.Fragment>
<div
className="bp5-dialog-body"
>
<Blueprint5.InputGroup
leftIcon="search"
onChange={[Function]}
placeholder="Search servers..."
style={
{
"marginBottom": 10,
}
}
value=""
/>
<div
style={
{
"maxHeight": 400,
"overflowY": "auto",
}
}
>
<div
style={
{
"marginBottom": 8,
}
}
>
<Blueprint5.Checkbox
checked={false}
indeterminate={true}
labelElement={
<React.Fragment>
<strong>
hot
</strong>
</React.Fragment>
}
onChange={[Function]}
/>
<div
style={
{
"paddingLeft": 20,
}
}
>
<Blueprint5.Checkbox
checked={true}
label="hot-host1:8083"
onChange={[Function]}
/>
<Blueprint5.Checkbox
checked={false}
label="hot-host2:8083"
onChange={[Function]}
/>
</div>
</div>
<div
style={
{
"marginBottom": 8,
}
}
>
<Blueprint5.Checkbox
checked={false}
indeterminate={false}
labelElement={
<React.Fragment>
<strong>
cold
</strong>
</React.Fragment>
}
onChange={[Function]}
/>
<div
style={
{
"paddingLeft": 20,
}
}
>
<Blueprint5.Checkbox
checked={false}
label="cold-host1:8083"
onChange={[Function]}
/>
</div>
</div>
</div>
</div>
<div
className="bp5-dialog-footer"
>
<div
className="bp5-dialog-footer-actions"
>
<span
style={
{
"alignSelf": "center",
"flex": 1,
}
}
>
1
server

selected
</span>
<Blueprint5.Button
onClick={[Function]}
text="Cancel"
/>
<Blueprint5.Button
intent="primary"
onClick={[Function]}
text="Save"
/>
</div>
</div>
</React.Fragment>
</Blueprint5.Dialog>
`;

exports[`ServerMultiSelectDialog matches snapshot with no selection 1`] = `
<Blueprint5.Dialog
canOutsideClickClose={true}
className="server-multi-select-dialog"
isOpen={true}
onClose={[Function]}
title="Decommissioning nodes"
>
<React.Fragment>
<div
className="bp5-dialog-body"
>
<Blueprint5.InputGroup
leftIcon="search"
onChange={[Function]}
placeholder="Search servers..."
style={
{
"marginBottom": 10,
}
}
value=""
/>
<div
style={
{
"maxHeight": 400,
"overflowY": "auto",
}
}
>
<div
style={
{
"marginBottom": 8,
}
}
>
<Blueprint5.Checkbox
checked={false}
indeterminate={false}
labelElement={
<React.Fragment>
<strong>
hot
</strong>
</React.Fragment>
}
onChange={[Function]}
/>
<div
style={
{
"paddingLeft": 20,
}
}
>
<Blueprint5.Checkbox
checked={false}
label="hot-host1:8083"
onChange={[Function]}
/>
<Blueprint5.Checkbox
checked={false}
label="hot-host2:8083"
onChange={[Function]}
/>
</div>
</div>
<div
style={
{
"marginBottom": 8,
}
}
>
<Blueprint5.Checkbox
checked={false}
indeterminate={false}
labelElement={
<React.Fragment>
<strong>
cold
</strong>
</React.Fragment>
}
onChange={[Function]}
/>
<div
style={
{
"paddingLeft": 20,
}
}
>
<Blueprint5.Checkbox
checked={false}
label="cold-host1:8083"
onChange={[Function]}
/>
</div>
</div>
</div>
</div>
<div
className="bp5-dialog-footer"
>
<div
className="bp5-dialog-footer-actions"
>
<span
style={
{
"alignSelf": "center",
"flex": 1,
}
}
>
0
server
s
selected
</span>
<Blueprint5.Button
onClick={[Function]}
text="Cancel"
/>
<Blueprint5.Button
intent="primary"
onClick={[Function]}
text="Save"
/>
</div>
</div>
</React.Fragment>
</Blueprint5.Dialog>
`;
5 changes: 4 additions & 1 deletion .../src/dialogs/coordinator-dynamic-config-dialog/coordinator-dynamic-config-dialog.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,16 @@
* limitations under the License.
*/

import { Capabilities } from '../../helpers';
import { shallow } from '../../utils/shallow-renderer';

import { CoordinatorDynamicConfigDialog } from './coordinator-dynamic-config-dialog';

describe('CoordinatorDynamicConfigDialog', () => {
it('matches snapshot', () => {
const coordinatorDynamicConfig = shallow(<CoordinatorDynamicConfigDialog onClose={() => {}} />);
const coordinatorDynamicConfig = shallow(
<CoordinatorDynamicConfigDialog capabilities={Capabilities.FULL} onClose={() => {}} />,
);

expect(coordinatorDynamicConfig).toMatchSnapshot();
});
Expand Down
Loading
Loading