Skip to content

CASSSIDECAR-419 : Add Docker compose setup for CDC#330

Open
jyothsnakonisa wants to merge 2 commits intoapache:trunkfrom
jyothsnakonisa:cdc-docker-compose
Open

CASSSIDECAR-419 : Add Docker compose setup for CDC#330
jyothsnakonisa wants to merge 2 commits intoapache:trunkfrom
jyothsnakonisa:cdc-docker-compose

Conversation

@jyothsnakonisa
Copy link
Copy Markdown
Contributor

No description provided.


## Architecture

```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, easy to understand for new users

Copy link
Copy Markdown
Contributor

@skoppu22 skoppu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


YAML="/etc/cassandra/cassandra.yaml"

patch_yaml() {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding a "didn't find it, couldn't patch" style warning or error here?

build.gradle Outdated
"-Dsidecar.config=" + confFile,
"-Dlogback.configurationFile=" + logbackConfFile,
"-Dvertx.logger-delegate-factory-class-name=io.vertx.core.logging.SLF4JLogDelegateFactory"]
if (JavaVersion.current().isJava11Compatible()) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants