cm: networkmanager: fix early return in RemoveInstanceNetworkParameters#200
Open
MykolaSuperman wants to merge 1 commit intoaosedge:developfrom
Open
cm: networkmanager: fix early return in RemoveInstanceNetworkParameters#200MykolaSuperman wants to merge 1 commit intoaosedge:developfrom
MykolaSuperman wants to merge 1 commit intoaosedge:developfrom
Conversation
Replace `return eNone` with `continue` when instance is not found in a network's host instances. The early return prevented searching other networks, leaving the instance in memory for the old node. During provider network cleanup the same instance was deleted from DB twice: first deletion succeeded, second got eNotFound and threw an error. Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #200 +/- ##
==========================================
Coverage ? 82.42%
==========================================
Files ? 325
Lines ? 31153
Branches ? 3228
==========================================
Hits ? 25678
Misses ? 5475
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
return eNonewithcontinuewhen instance is not found in a network's host instances. The early return prevented searching other networks, leaving the instance in memory for the old node. During provider network cleanup the same instance was deleted from DB twice: first deletion succeeded, second got eNotFound and threw an error.