cm: communication: suppress template recursion error in tests#199
cm: communication: suppress template recursion error in tests#199mlohvynenko wants to merge 1 commit intoaosedge:feature_release_9.1from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_release_9.1 #199 +/- ##
======================================================
Coverage ? 82.42%
======================================================
Files ? 325
Lines ? 31154
Branches ? 3218
======================================================
Hits ? 25680
Misses ? 5474
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| StaticArray<StaticString<oci::cDigestLen>, 1> digests; | ||
| digests.EmplaceBack(cDigest); | ||
| // cppcheck-suppress templateRecursion | ||
| auto digests = std::make_unique<StaticArray<StaticString<oci::cDigestLen>, 1>>(); |
There was a problem hiding this comment.
Digest is small, do you really need to make it unique?
There was a problem hiding this comment.
agree
kept only cpp check suppression
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
|
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
al1img
left a comment
al1img
left a comment
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
3 participants
No description provided.