Fix compiler warnings related to Crystal 1.14#232
Closed
mloughran wants to merge 2 commits intoanykeyh:masterfrom
Closed
Fix compiler warnings related to Crystal 1.14#232mloughran wants to merge 2 commits intoanykeyh:masterfrom
mloughran wants to merge 2 commits intoanykeyh:masterfrom
Conversation
Fixes deprecation warnings of the form:
```
In spec/sql/select/lock_spec.cr:22:7
22 | sleep(0.05) # Give hand to the other fiber. Now it should be not locked anymore?
^----
Warning: Deprecated ::sleep. Use `::sleep(Time::Span)` instead
```
Fixes:
```
In src/clear/expression/expression.cr:86:17
86 | def to_json(b = nil)
^
Warning: positional parameter 'b' corresponds to parameter 'x' of the overridden method Clear::Expression::Literal#to_json(x : JSON::Builder), which has a different name and may affect named argument passing
```
mloughran
changed the title
Contributor
Author
Owner
|
Yeah, I will close this one, as I added the changes in 0.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes compiler warnings, which I've detailed in the commit commits. This should be a no-op change.
Motivation and Context
Clean buids.
How Has This Been Tested?
Types of changes
Checklist:
bin/amebaran without alert.