Check num combinations aginst threshold before generating paths#84
Open
Dogfalo wants to merge 1 commit intoantonmedv:masterfrom
Open
Check num combinations aginst threshold before generating paths#84Dogfalo wants to merge 1 commit intoantonmedv:masterfrom
Dogfalo wants to merge 1 commit intoantonmedv:masterfrom
Conversation
antonmedv
requested changes
Sep 6, 2024
| if (paths.length > config.threshold) { | ||
| return fallback ? fallback() : null | ||
| // Check first the total number of combinations first since generating the combinations can cause memory exhaustion | ||
| const numCombinations = stack.reduce((acc, i) => acc * i.length, 1); |
Owner
There was a problem hiding this comment.
I'm not sure about this calculation logic. Better more the if into combinations() generator and throw an error of limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check Number of Combinations Against Threshold Before Generating Paths
Summary
This pull request adds a safeguard against potential memory exhaustion in the
findUniquePathfunction by checking the total number of possible combinations before generating them.Description
In the
findUniquePathfunction, generating combinations of paths can lead to high memory usage if the number of combinations is large.This update introduces a check that calculates the total number of combinations before proceeding to generate the combinations. If the number of combinations exceeds the configured threshold, the function will return a fallback path (if provided) or
null.Changes Made