Implement nth-of-type when we are including the tagName#71
Open
eoghanmurray wants to merge 1 commit intoantonmedv:masterfrom
Open
Implement nth-of-type when we are including the tagName#71eoghanmurray wants to merge 1 commit intoantonmedv:masterfrom
eoghanmurray wants to merge 1 commit intoantonmedv:masterfrom
Conversation
Author
|
Highlighting one unexpected change to the test results ... the following is preferred as the algo immediately cuts off if a unique match is found at a given level: Before, I don't know if it's desirable to fix this or not? And don't know how best to fix. Note: up for debate, but the 'desired' selector would be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of
nth-of-type#3The idea here is to never allow the combination of a tagName + :nth-child — from the point of view that it's
(reasons given by @kfrederix)