Fix broken multi-line comment highlighting #115
Open
davidklassen wants to merge 1 commit intoantirez:masterfrom
Open
Fix broken multi-line comment highlighting #115davidklassen wants to merge 1 commit intoantirez:masterfrom
davidklassen wants to merge 1 commit intoantirez:masterfrom
Conversation
davidklassen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114
editorDelRow() uses idx++ to update row indices after deletion, but it should be idx--. Rows shift up when deleted (the inverse of insertion), so their indices must decrease. The wrong direction corrupts row.idx, which breaks editorUpdateSyntax() — it uses row->idx + 1 to propagate comment state to the next row, but the inflated index makes the bounds check fail and propagation stops silently.