fix: type hints for meshing workflows#4925
Draft
Gobot1234 wants to merge 7 commits intojhilton/typing-improvementsfrom
Draft
fix: type hints for meshing workflows#4925Gobot1234 wants to merge 7 commits intojhilton/typing-improvementsfrom
Gobot1234 wants to merge 7 commits intojhilton/typing-improvementsfrom
Conversation
Collaborator
Author
…om/ansys/pyfluent into jhilton/fix-meshing-workflow-types
Collaborator
Author
|
Small update had a chat with Prithwish and realised this is missing workflow.task_object.create_surface_mesh.cfd_surface_mesh_controls(
# ^^^^^^^^^^^^^^^^^^^^^^^^^ this shouldn't be Unknown but is
curvature_normal_angle=12,
growth_rate=1.15,
max_size=50,
min_size=1,
size_functions="Curvature"
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
Fixes #4772 by adding intellisense for the meshing classes by making their proxying behaviour typed.
Change Summary
Adds types and tests for the meshing workflows
Impact
No user noticeable runtime changes only changed class names to stop interfering with type checking, added tests and a couple imports
NB I've intentionally picked the base to be my branch to make changes easier to review, should be merged onto main once the base is merged.