Skip to content

fix: type hints for meshing workflows#4925

Draft
Gobot1234 wants to merge 7 commits intojhilton/typing-improvementsfrom
jhilton/fix-meshing-workflow-types
Draft

fix: type hints for meshing workflows#4925
Gobot1234 wants to merge 7 commits intojhilton/typing-improvementsfrom
jhilton/fix-meshing-workflow-types

Conversation

@Gobot1234
Copy link
Copy Markdown
Collaborator

Context

Fixes #4772 by adding intellisense for the meshing classes by making their proxying behaviour typed.

Change Summary

Adds types and tests for the meshing workflows

Impact

No user noticeable runtime changes only changed class names to stop interfering with type checking, added tests and a couple imports

NB I've intentionally picked the base to be my branch to make changes easier to review, should be merged onto main once the base is merged.

@github-actions github-actions bot added the bug Issue, problem or error in PyFluent label Feb 11, 2026
@Gobot1234
Copy link
Copy Markdown
Collaborator Author

Gobot1234 commented Feb 13, 2026

image

Not sure if something similar can be done for the old workflow I imagine that's nightmarish to try and type all the TypedDicts for arguments. At least attribute access should be fully typed

@Gobot1234
Copy link
Copy Markdown
Collaborator Author

Small update had a chat with Prithwish and realised this is missing

workflow.task_object.create_surface_mesh.cfd_surface_mesh_controls(  
                                      # ^^^^^^^^^^^^^^^^^^^^^^^^^ this shouldn't be Unknown but is
    curvature_normal_angle=12,
    growth_rate=1.15,
    max_size=50,
    min_size=1,
    size_functions="Curvature"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyFluent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants