Skip to content

chore: Activate failing tests. #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prmukherj wants to merge 3 commits into from
Closed

chore: Activate failing tests. #4850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
245abff
chore: Activate failing tests.
prmukherj Jan 22, 2026
bb29c6a
chore: adding changelog file 4850.maintenance.md [dependabot-skip]
pyansys-ci-bot Jan 22, 2026
5472578
Add another test.
prmukherj Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/4850.maintenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Activate failing tests.
2 changes: 0 additions & 2 deletions tests/parametric/test_parametric_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
from ansys.fluent.core.utils.fluent_version import FluentVersion


@pytest.mark.skip(reason="https://github.com/ansys/pyfluent/issues/3855")
@pytest.mark.nightly
@pytest.mark.fluent_version("latest")
def test_parametric_workflow():
# parent path needs to exist for mkdtemp
Expand Down
1 change: 0 additions & 1 deletion tests/test_flobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,6 @@ def test_settings_api_names_exception(new_solver_session):
solver.setup.boundary_conditions["cold-inlet"].name = "hot-inlet"


@pytest.mark.skip(reason="https://github.com/ansys/pyfluent/issues/4645")
@pytest.mark.fluent_version(">=24.2")
def test_accessor_methods_on_settings_objects(new_solver_session):
solver = new_solver_session
Expand Down
26 changes: 12 additions & 14 deletions tests/test_settings_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,20 +681,18 @@ def test_settings_with_deprecated_flag(mixing_elbow_settings_session):
# User won't normally find deprecated objects in the settings API, so it is OK to leave them active.
assert graphics.contour["contour-velocity"].range_options.is_active()

# https://github.com/ansys/pyfluent/issues/3813
# in 'get_state'
# if solver.get_fluent_version() >= FluentVersion.v252:
# # From v252 'get_state' behaviour is to be corrected in Fluent.
# assert not {"range_option", "coloring"}.issubset(
# set(graphics.contour["contour-velocity"].get_state())
# )
# assert {"range_options", "colorings"}.issubset(
# set(graphics.contour["contour-velocity"].get_state())
# )
# else:
# assert {"range_option", "range_options", "coloring", "colorings"}.issubset(
# set(graphics.contour["contour-velocity"].get_state())
# )
if solver.get_fluent_version() >= FluentVersion.v252:
# From v252 'get_state' behaviour is to be corrected in Fluent.
assert not {"range_option", "coloring"}.issubset(
set(graphics.contour["contour-velocity"].get_state())
)
assert {"range_options", "colorings"}.issubset(
set(graphics.contour["contour-velocity"].get_state())
)
else:
assert {"range_option", "range_options", "coloring", "colorings"}.issubset(
set(graphics.contour["contour-velocity"].get_state())
)

# in 'child_names'
# 'child_names', 'command_names' and 'query_names' will remain unchanged.
Expand Down
Loading