[Snyk] Security upgrade django from 2.2.28 to 4.2.26#108
[Snyk] Security upgrade django from 2.2.28 to 4.2.26#108
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-13836728 - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-13837025
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to upgrade Django from 2.2.28 to 4.2.26 to address security vulnerabilities identified by Snyk. However, the upgrade is incomplete and will likely fail due to conflicting constraints.
Key Changes
- Updates Django version in requirements/dev.txt from 2.2.28 to 4.2.26
- This is a major version jump spanning two Django major versions (2.2 → 4.2)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # -r requirements/test.txt | ||
| # virtualenv | ||
| django==2.2.28 | ||
| django==4.2.26 |
There was a problem hiding this comment.
Incomplete upgrade: While dev.txt is updated to Django 4.2.26, requirements/django.txt still specifies django==2.2.28, and more critically, requirements/django.in has an explicit constraint Django>=2.2,<3.0 that will prevent Django 4.2.26 from being installed. All three files need to be updated consistently for the upgrade to work. Additionally, setup.py classifiers list Django 3.2 and 4.0 support but not 4.2.
| # -r requirements/test.txt | ||
| # virtualenv | ||
| django==2.2.28 | ||
| django==4.2.26 |
There was a problem hiding this comment.
Major version upgrade without migration plan: Upgrading from Django 2.2 to 4.2 spans two major versions and includes breaking changes. The CHANGELOG.rst shows Django 4.2 support was added in version 1.7.0, but this PR doesn't address potential breaking changes in middleware configuration (xblock/test/settings.py uses older middleware patterns), deprecated APIs, or template syntax changes. A comprehensive testing and migration strategy should be documented.



Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements/dev.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection