writeFile expects string or buffer not int in newer versions of node#100
Open
ahinni wants to merge 8 commits intoandrewrk:masterfrom
Open
writeFile expects string or buffer not int in newer versions of node#100ahinni wants to merge 8 commits intoandrewrk:masterfrom
ahinni wants to merge 8 commits intoandrewrk:masterfrom
Conversation
We needed to convert the pid to a string so we could write to the pid file.
Author
|
Sorry, just realized that this included a different package json. Happy to change if this repo is still being managed. Otherwise, perhaps this will help others. |
We couldn't figure out how to do a public package on github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In upgrading away from version 12 of node, we were getting errors that writeFile was expecting a string or buffer. This simply converts the
process.pidto a string.