extmod/bluetooth: Add gap_unpair() for all BLE backends.#24
Draft
andrewleech wants to merge 1 commit intoreview/gap-unpairfrom
Draft
extmod/bluetooth: Add gap_unpair() for all BLE backends.#24andrewleech wants to merge 1 commit intoreview/gap-unpairfrom
andrewleech wants to merge 1 commit intoreview/gap-unpairfrom
Conversation
Add mp_bluetooth_gap_unpair() to the common bluetooth API, with implementations for NimBLE, BTstack, and Zephyr BLE backends. Allows applications to programmatically remove bonding information for a specific peer. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There's no way to programmatically remove bonding keys in the current BLE API. Tests that pair/bond need to clear stale keys on startup to avoid failures from leftover state, and applications that manage multiple bonds need per-peer removal.
This adds
BLE.gap_unpair()with two forms: no-arg clears all bonds, two-arg(addr_type, addr)removes a specific peer. Implemented for NimBLE (ble_gap_terminate+ble_store_util_delete_peer) and BTstack (gap_delete_bonding). The Zephyr backend already has a dormant implementation that activates when the Zephyr BLE integration lands.Testing
ble_gap_unpair.pytest added: connects, pairs with bonding, disconnects, then calls per-addressgap_unpair()on both sides.gap_unpair()no-arg calls added toble_gap_pair.py,ble_gap_pair_bond.py, andble_subscribe.pystartup to clear stale bonds.Generative AI
I used generative AI tools when creating this PR, but a human has checked the code and is responsible for the description above.