Merged
Conversation
e0c392b to
9d29e1d
Compare
Contributor
|
Plugin builds for ee6f7c7 are ready 🛎️!
|
dhaval-parekh
approved these changes
Feb 21, 2022
Collaborator
dhaval-parekh
left a comment
There was a problem hiding this comment.
Changes looks good to me.
Member
Author
|
Eesh. I just found that the patches fail to apply when running |
Member
Author
|
Yeah, it's also failing in the GHA build: I believe it's due to the patches including changes to |
4bee0af to
0d16778
Compare
0d16778 to
ee6f7c7
Compare
Collaborator
|
@dhaval-parekh Please could you review this again further to the findings @westonruter shared and new changes pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changelog for v8.4.0.
PHP-CSS-Parser went a long time without a release. Version 8.3.0 was released 2019-02-22, and in order to deploy unreleased improvements we updated to include the commits we needed (#4300, #5081) in addition to applying additional patches (#5392, #4290, etc).
Changes between v8.3.0 and what we released: MyIntervals/PHP-CSS-Parser@8.3.0...bfdd976
Changes between what we released and v8.4.0: MyIntervals/PHP-CSS-Parser@bfdd976...8.4.0
So this PR updates to the latest stable release as well as:
Additional patches on top of v8.4.0 are applied from these PRs:
turnsunit withturnMyIntervals/PHP-CSS-Parser#350