chore: use lockfiles for NPM dependencies#80
Open
daniel-graham-amplitude wants to merge 1 commit intomainfrom
Open
chore: use lockfiles for NPM dependencies#80daniel-graham-amplitude wants to merge 1 commit intomainfrom
daniel-graham-amplitude wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to use a committed npm lockfile (instead of npx -p ...) so semantic-release runs with deterministic dependency resolution.
Changes:
- Add root
package.json/package-lock.jsonand update release workflow to runnpm ci+npm exec semantic-release. - Update
.gitignoreto excludenode_modules/. - Switch semantic-release execution from inline
npx -pinstalls to local, lockfile-resolved tooling.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
package.json |
Introduces pinned npm dependencies used by the release workflow. |
package-lock.json |
Locks the dependency graph for deterministic installs in CI (npm ci). |
.gitignore |
Ignores node_modules/ in the repo. |
.github/workflows/release.yml |
Runs npm ci before semantic-release and executes semantic-release via npm exec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+48
| npm ci | ||
| npm exec semantic-release -- --dry-run |
| "@semantic-release/git": "9.0.1", | ||
| "@google/semantic-release-replace-plugin": "1.0.0", | ||
| "@semantic-release/exec": "5.0.0", | ||
| "semantic-release-rubygem": "latest" |
Comment on lines
+4
to
+9
| "lodash": "4.17.21", | ||
| "semantic-release": "17.4.7", | ||
| "@semantic-release/changelog": "5.0.1", | ||
| "@semantic-release/git": "9.0.1", | ||
| "@google/semantic-release-replace-plugin": "1.0.0", | ||
| "@semantic-release/exec": "5.0.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the equivalent of amplitude/Amplitude-Swift#350 in this repository.
Changes
npx -p ...installs to lockfile-based commandsnpm cibefore semantic-release in dry-run and release stepsnpm execpackage.json+package-lock.jsonfor deterministic dependency resolutionnode_modules/in.gitignorewhere needed