Skip to content

chore: use lockfiles for NPM dependencies#80

Open
daniel-graham-amplitude wants to merge 1 commit intomainfrom
codex/release-lockfiles
Open

chore: use lockfiles for NPM dependencies#80
daniel-graham-amplitude wants to merge 1 commit intomainfrom
codex/release-lockfiles

Conversation

@daniel-graham-amplitude

Applies the equivalent of amplitude/Amplitude-Swift#350 in this repository.

Changes

  • switch release workflow from inline npx -p ... installs to lockfile-based commands
  • run npm ci before semantic-release in dry-run and release steps
  • run semantic-release via npm exec
  • add root package.json + package-lock.json for deterministic dependency resolution
  • ignore node_modules/ in .gitignore where needed

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow to use a committed npm lockfile (instead of npx -p ...) so semantic-release runs with deterministic dependency resolution.

Changes:

  • Add root package.json / package-lock.json and update release workflow to run npm ci + npm exec semantic-release.
  • Update .gitignore to exclude node_modules/.
  • Switch semantic-release execution from inline npx -p installs to local, lockfile-resolved tooling.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Introduces pinned npm dependencies used by the release workflow.
package-lock.json Locks the dependency graph for deterministic installs in CI (npm ci).
.gitignore Ignores node_modules/ in the repo.
.github/workflows/release.yml Runs npm ci before semantic-release and executes semantic-release via npm exec.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +47 to +48
npm ci
npm exec semantic-release -- --dry-run
"@semantic-release/git": "9.0.1",
"@google/semantic-release-replace-plugin": "1.0.0",
"@semantic-release/exec": "5.0.0",
"semantic-release-rubygem": "latest"
Comment on lines +4 to +9
"lodash": "4.17.21",
"semantic-release": "17.4.7",
"@semantic-release/changelog": "5.0.1",
"@semantic-release/git": "9.0.1",
"@google/semantic-release-replace-plugin": "1.0.0",
"@semantic-release/exec": "5.0.0",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants