Update Debug impls for cell::Ref/cell::RefMut to show value (and bump MSRV)#228
Merged
Imberflur merged 2 commits intoamethyst:masterfrom Apr 24, 2023
Merged
Update Debug impls for cell::Ref/cell::RefMut to show value (and bump MSRV)#228Imberflur merged 2 commits intoamethyst:masterfrom
Imberflur merged 2 commits intoamethyst:masterfrom
Conversation
… that they internally use `NonNull`
Note, this is still lower than the MSRV used in `specs`. I bumped this because rayon-core v1.11.0 requires this version and the CI was failing since there is no lockfile pinning this to an older rayon-core version.
Imberflur
changed the title
zesterer
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#223 accidentally regressed the debug impls, here we now show the referenced values again but the atomic counter is omitted