Clean shim_test workspace for legacy binary location#1209
Open
Clean shim_test workspace for legacy binary location#1209
Conversation
Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates shim_test to use the canonical local_shim_test_data/... layout for legacy xclbin locations, removing legacy workspace symlink setup.
Changes:
- Switch NPU1/NPU4/NPU5/NPU6 legacy
.xclbinpaths indev_info.cpptolocal_shim_test_data/.... - Remove install-time symlink creation for
npu*_workspacedirectories and rely on a singlelocal_shim_test_datasymlink. - Fix a typo in a linker flag comment (
--disable-new-dtags).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/shim_test/dev_info.cpp |
Repoints legacy xclbin paths to local_shim_test_data hierarchy. |
test/shim_test/CMakeLists.txt |
Removes npu*_workspace symlink setup; keeps/uses local_shim_test_data symlink and fixes comment typo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.