feat: better handling of drush commands outside of Lagoon environments#38
Open
rocketeerbkw wants to merge 1 commit intomainfrom
Open
feat: better handling of drush commands outside of Lagoon environments#38rocketeerbkw wants to merge 1 commit intomainfrom
rocketeerbkw wants to merge 1 commit intomainfrom
Conversation
Allows all `lagoon` commands to be run in DDEV
rocketeerbkw
force-pushed
the
ddev-support
branch
from
27f5600 to
e63c52e
Compare
bomoko
approved these changes
Mar 30, 2026
| * @var string | ||
| */ | ||
| private $api; | ||
| private $api = 'https://api.lagoon.amazeeio.cloud/graphql'; |
Contributor
There was a problem hiding this comment.
I'm not entirely against this - just I know we had some focus around not hardcoding this stuff into the integrations work before. Thoughts?
Member
Author
There was a problem hiding this comment.
I think removing the hardcoded values at this moment would break these drush commands for the majority of users, not just "outside of lagoon environments"? They aren't in .lagoon.yml by default and the env vars LAGOON_OVERRIDE_API/LAGOON_OVERRIDE_SSH are non-standard (not set by Lagoon).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #23, a brute force check for
LAGOONenv var was added to prevent errors when attempting to run any Drush command in a non-lagoon environment. This had the side effect of preventing drush lagoon commands from running in environments that could work, but aren't Lagoon, like DDEV.This PR changes so that the specific error is caught and handled, instead of disabling all together. This allows all
lagooncommands to be run in DDEV as well.Supersedes #24.
Note for reviewers. There was inconsistent spelling of variables
jwt_token/jwttokenandssh_port_timeout/sshTimeoutthroughout. It looked like a bug to me so I unified them all.