Mysql 0.5.7: use the adapter connection parameters to get the password instead#99
Open
HoneyryderChuck wants to merge 2 commits intoamatsuda:masterfrom
Open
Mysql 0.5.7: use the adapter connection parameters to get the password instead#99HoneyryderChuck wants to merge 2 commits intoamatsuda:masterfrom
HoneyryderChuck wants to merge 2 commits intoamatsuda:masterfrom
Conversation
the previous fix loaded the db_config from the pool, but this had the drawback of getting the config from the default shard; this breaks when handling multiple shards. and besides, the connection actually holds enough information to perform the connection except for the password, which was the 0.5.7 breaking change. this fixes it by tapping unto the `@connection_parameters` ivar instead, which is still in use in rails master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the previous fix loaded the db_config from the pool, but this had the
drawback of getting the config from the default shard; this breaks when
handling multiple shards. and besides, the connection actually holds
enough information to perform the connection except for the password,
which was the 0.5.7 breaking change.
this fixes it by tapping unto the
@connection_parametersivar instead,which is still in use in rails master.